[Webkit-unassigned] [Bug 88473] Web Inspector: Implement ExtensionPanel.show() method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 11 11:55:17 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88473





--- Comment #20 from Andrey Kosyakov <caseq at chromium.org>  2012-06-11 11:55:16 PST ---
(In reply to comment #19)
> (In reply to comment #16)
> > (From update of attachment 146646 [details] [details])
> > Looks much better now! Does the test still work?
> 
> Thanks! And yes, the test still works because it uses `extension_showPanel("extension")` to force the panel to show.
> 
> It would be nice to have a new test that clicks on a resource link and triggers the handler to show the panel, but that mixes up `extensions-resources.html` and `extensions-panel.html` and I didn't know how to make that work.

Yep -- we definitely need a test for the new method. Looks like it wold be mostly performed in the extension world, so I think it should be reasonably straightforward. You can move InspectorTest.clickOnURL to LayoutTests/http/tests/inspector/extensions-test.js and re-use it in your test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list