[Webkit-unassigned] [Bug 88704] [Qt][Texmap] Falling leaves demo missing clipping.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88704





--- Comment #6 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-06-11 06:08:57 PST ---
(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 146691 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=146691&action=review
> > 
> > > Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:-270
> > >      glDisable(GL_DEPTH_TEST);
> > >      glEnable(GL_SCISSOR_TEST);
> > > -#if PLATFORM(QT)
> > > -    if (m_context) {
> > > -        QPainter* painter = m_context->platformContext();
> > > -        painter->save();
> > > -        painter->beginNativePainting();
> > > -    }
> > > -#endif
> > 
> > Shouldn't the new code be called before the other GL calls?
> 
> Would you like to explain more detail. I think I don't understand what you mean.

i'm saying it should look more like this:

> > > -#if PLATFORM(QT)
> > > -    if (m_context) {
> > > -        QPainter* painter = m_context->platformContext();
> > > -        painter->save();
> > > -        painter->beginNativePainting();
> > > -    }
> > > -#endif
> > >      glDisable(GL_DEPTH_TEST);
> > >      glEnable(GL_SCISSOR_TEST);
> >

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.