[Webkit-unassigned] [Bug 88704] [Qt][Texmap] Falling leaves demo missing clipping.

Sun Jun 10 16:31:23 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=88704

--- Comment #3 from Huang Dongsung <luxtella at company100.net>  2012-06-10 16:31:23 PST ---
(From update of attachment 146691)
View in context: https://bugs.webkit.org/attachment.cgi?id=146691&action=review

>> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:-270
>> -#endif
> 
> Shouldn't the new code be called before the other GL calls?

I think there is no problem to put initializeOpenGLShims() before PLATFORM(QT) code, because initializeOpenGLShims() does not change any GL states and QPainter does not need something like OpenGLShims.
Moreover, I think it is more obvious to save gl states for QPainter before starting Texmap routines like TextureMapperGL::endPainting restores gl states for QPainter after all Texmap tasks are finished.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.