[Webkit-unassigned] [Bug 88735] New: [Qt] #ifdef foo && bar is not valid C/C++ preprocessor directive

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88735

           Summary: [Qt] #ifdef foo && bar is not valid C/C++ preprocessor
                    directive
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh Intel
        OS/Version: Mac OS X 10.7
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P3
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: timo.qt at aallonharju.net


Created an attachment (id=146738)
 --> (https://bugs.webkit.org/attachment.cgi?id=146738&action=review)
patch to fix invalid preprocessor directives

At least qtwebkit 5.0 (f2da9451cbccb8b7921d55483aa0bc656ff9cf53 (http://svn.webkit.org/repository/webkit/trunk@119269)) had some 

#ifdef foo || bar

preprocessor directives (apparently MSVC accepts them, C standard or e.g. gcc won't). 

At least one of them was hit by a compiler when compiling for OS X, don't know if it has any impact on anything though.

Attached is a patch that changes all such directives my grep found to the correct format

#if defined(foo) || defined(bar)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.