[Webkit-unassigned] [Bug 88630] [Texmap][EFL] Minor fixes to EFL accelerated compositing.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88630





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-09 03:55:19 PST ---
(From update of attachment 146505)
View in context: https://bugs.webkit.org/attachment.cgi?id=146505&action=review

WebKit tends to avoid to land multiple patches at once. Because, it can land insufficient reviewed patch. So, I also think you need to divide this patch.

> Source/WebCore/platform/graphics/GraphicsLayer.h:82
> +#elif PLATFORM(EFL)

Don't you need to use below macro ? QT and GTK have used this.

#if USE(TEXTURE_MAPPER)

> Source/WebCore/platform/graphics/OpenGLShims.cpp:20
> +#if ENABLE(WEBGL) || defined(QT_OPENGL_SHIMS) || (PLATFORM(EFL) && USE(ACCELERATED_COMPOSITING))

I don't understand why you need to add EFL and ACCELERATED_COMPOSITING macro. I think you can use this file by enabling WEBGL. Isn't it ?

>> Source/WebCore/platform/graphics/surfaces/GraphicsSurface.h:30
>>  
> 
> Well IIRC GraphicsSurface is just used right now by Qt in WK2. These changes should be in other patch.

As Igor said, you need to get review from Qt and WK2 reviewers. And also, it looks you need to write patch description more details. Because, this is common file for some ports.

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:88
> +#elif defined(XP_UNIX) && !PLATFORM(EFL)

As Igor said, you have to explain why EFL port doesn't want to enable this.

> Source/WebKit/efl/WebCoreSupport/PageClientEfl.cpp:40
> +bool PageClientEfl::createEvasObjectForAcceleratedCompositing(Evas_Native_Surface* nativeSurface, const WebCore::IntRect& rect)

In EFL port, we have used IntRect directly by including "IntRect.h".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.