[Webkit-unassigned] [Bug 88695] New: _commit_queue_flag in bugzilla.py is a confusing interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88695

           Summary: _commit_queue_flag in bugzilla.py is a confusing
                    interface
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dpranke at chromium.org
                CC: eric at webkit.org, abarth at webkit.org, ojan at chromium.org,
                    rniwa at webkit.org


we have both 'mark_for_landing' and 'mark_for_commit_queue'. the first means, if True, set the flag to cq+; the second means, if True, set the flag to 'cq?', but that name is not obvious to me. It's also not obvious what happens if both flags are True. This would probably be better as a single 4-state field (blank, cq-, cq?, cq+).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.