[Webkit-unassigned] [Bug 88691] New: [BlackBerry] Fix two problems introduced by the userDrivenSeekTimer in MediaPlayerPrivate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 14:48:01 PDT 2012


           Summary: [BlackBerry] Fix two problems introduced by the
                    userDrivenSeekTimer in MediaPlayerPrivate
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Other
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit BlackBerry
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mfeil at rim.com
                CC: tonikitoo at webkit.org

The main fix that my patch covers is for short media. The m_userDrivenSeekTimer is causing unwanted repeats of short media such as sound effects because it is causing the current time to not reflect that the media has finished playing. This problem only affects media whose duration is close to or less than the SeekSubmissionDelay, which is currently set to 100ms. My fix is to ignore the userDrivenSeekTimer in MediaPlayerPrivate::currentTime() if the duration of the media is within twice the SeekSubmissionDelay. Seek drag smoothness is a non-issue for such short media.

I discovered this problem on the BrickBreakerRevolution game. The sound of the ball hitting the paddle or bricks would  repeat. I have written an automated test using a sound effect from the game.

A second less serious problem is the way the m_userDrivenSeekTimer itself is implemented. When MediaPlayerPrivate::seek() is called, there is always a 100ms delay even if the timer is not running! The timer is supposed to space out multiple seeks, but currently it is slowing down even single seeks. I fixed this in my patch by improving the way the timer fired function is called.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list