[Webkit-unassigned] [Bug 88268] [chromium] Expose rendering statistics to WebLayerTreeView.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88268





--- Comment #4 from Dave Tu <dtu at chromium.org>  2012-06-08 14:04:45 PST ---
(From update of attachment 145658)
View in context: https://bugs.webkit.org/attachment.cgi?id=145658&action=review

>> Source/Platform/chromium/public/WebLayerTreeView.h:50
>> +    int implFrameCount;
> 
> any alternative names for paintFrameCount? painting is pretty overloaded. frameCount would be okay.
> 
> Put //s on each explaining what they are.
> 
> I know its annoying, but this has to be its own file.

Done.

>> Source/Platform/chromium/public/WebLayerTreeView.h:181
>> +    WEBKIT_EXPORT void renderingStatistics(WebRenderingStatistics&);
> 
> When we extend this to things like "time spent in paint" how is this API going to work? Are we just going to hope that the counters dont overflow? Or will we add a reset function? I dont care, but we should think it through now.

For the frame counters, it's okay because it's (2^31-1)/120/60/60/24 = 207 days before it overflows at 120 fps. For "time spent in paint," probably floating point types. The Javascript API would convert them all to doubles anyway.

>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:200
>> +    int implFrameNumber() const { return m_proxy->implFrameNumber(); }
> 
> I think this should have a renderingStatistics API too. The WLTVI changes should just be passthrough to CCLTH

Done.

>> Source/WebCore/platform/graphics/chromium/cc/CCProxy.h:82
>> +    virtual int implFrameNumber() = 0;
> 
> What happens if we want more impl-side rendering stats? E.g. time spent in draw? Would it be better to have a method on the proxy saying "fill your impl side stats into this WebRenderingStatistics struct?" That way when we add other stats we dont have to add yet-more proxy emthods

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.