[Webkit-unassigned] [Bug 88675] [BlackBerry] Fix crash on PagePopupChromeClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88675





--- Comment #4 from Antonio Gomes <tonikitoo at webkit.org>  2012-06-08 12:32:10 PST ---
(From update of attachment 146626)
View in context: https://bugs.webkit.org/attachment.cgi?id=146626&action=review

looks better. two questions ...

> Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp:315
>  void ChromeClientBlackBerry::closePagePopup(PagePopup* popup)

is popup unused now?

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:129
> +    if (m_webPage->m_webPage->hasOpenedPopup())
> +        m_webPage->m_page->chrome()->client()->closePagePopup(0);

does it make sense to move the hasOpenedPopup check inside ::closePagePopup()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.