[Webkit-unassigned] [Bug 88344] Fix FastMalloc.cpp compile error for MSVC in 64-bit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88344


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145851|review+                     |review-
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-08 11:07:15 PST ---
(From update of attachment 145851)
View in context: https://bugs.webkit.org/attachment.cgi?id=145851&action=review

>> Source/WTF/wtf/FastMalloc.cpp:2477
>>   private:
>> -  char pad_[(64 - (sizeof(TCMalloc_Central_FreeList) % 64)) % 64];
>> +    char pad[64 - (sizeof(TCMalloc_Central_FreeList) % 64)];
> 
> Clearly, whoever wrote this code didn't test it :(

On my second thought you should wrap this with
#if sizeof(TCMalloc_Central_FreeList) % 64
#endif
so that we don't increase the size when sizeof(TCMalloc_Central_FreeList) is a multiple of 64.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.