[Webkit-unassigned] [Bug 88334] Prefer higher specificity selectors for rule set keys

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88334


Adam Roben (:aroben) <aroben at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #146602|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #13 from Adam Roben (:aroben) <aroben at webkit.org>  2012-06-08 10:49:34 PST ---
(From update of attachment 146602)
View in context: https://bugs.webkit.org/attachment.cgi?id=146602&action=review

> Source/WebCore/css/CSSParserValues.cpp:118
> +bool CSSParserSelector::hasPseudoElement()
> +{
> +  CSSParserSelector* selector = this;
> +  while (selector) {
> +    if (selector->m_selector->matchesPseudoElement())
> +      return true;
> +    selector = selector->tagHistory();
> +  }
> +  return false;
> +}

WebKit coding style is to use 4 spaces for indentation, not 2.

I think this could be written a little more clearly as a for loop.

Do we need to worry about the performance implications of this extra loop?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.