[Webkit-unassigned] [Bug 88663] Renamed DeviceOrientation to DeviceOrientationData

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 09:59:33 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88663





--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-06-08 09:59:31 PST ---
Attachment 146589 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1
Source/WebKit/chromium/src/WebDeviceOrientationController.cpp:38:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list