[Webkit-unassigned] [Bug 87805] [Shadow DOM] <style> inside Shadow subtree should be scoped inside the subtree.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 8 09:26:08 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87805


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #146465|review?                     |review+
               Flag|                            |




--- Comment #11 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-06-08 09:26:07 PST ---
(From update of attachment 146465)
View in context: https://bugs.webkit.org/attachment.cgi?id=146465&action=review

This turned out to be a sweet patch. Thanks for your hard work, tasak@! A few nits that you are welcome to ignore (except spelling errors :).

> Source/WebCore/ChangeLog:41
> +        method is invoked. Therefor we cannot rely on scoped()"

Therefor -> therefore

> Source/WebCore/ChangeLog:58
> +        Added one new method scopedAttributeChanged's decalartion and

decalartion -> declaration

> Source/WebCore/html/HTMLStyleElement.h:89
> +    enum ScopedStyleRegisterType {

ScopedStyleRegistrationState

> Source/WebCore/html/HTMLStyleElement.h:94
> +    ScopedStyleRegisterType m_registeredWithScopingNode;

m_scopedStyleRegistrationState

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list