[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003





--- Comment #23 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-06-08 04:39:05 PST ---
(In reply to comment #22)
> >  Source/WebCore/bindings/js/ScriptDebugServer.h:153
> >+    mutable BreakpointsInLine m_lastHitScriptBreakpoints;
> 
> Why do you need these fields to be mutable?

The function "hasBreakpoint" is a const function, I just don't want to break the original design. Maybe I should just change it as a normal function and avoid "mutable". 

> hasBreakpoint is used in one place only as far as I can see, doesn't look like a valuable design to keep to me :)

Yes, it looks like redundant :). But actually it's the heart of JSC debugger. Since the breakpoint in JSC is "fake" breakpoint. It's not inserted in JS code. If debugger is attached, interpreter just calling ScriptController to check if the breakpoint is reached at current line using "hasBreakpoint". So "hasBreakpoint" is almost invoked by every JS statement interpreting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.