[Webkit-unassigned] [Bug 72103] box-shadow creates incorrect shadow when border-radius is too large

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72103





--- Comment #12 from Takashi Sakamoto <tasak at google.com>  2012-06-08 00:30:12 PST ---
(In reply to comment #10)
> (From update of attachment 146249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146249&action=review
> 
> > Source/WebCore/platform/graphics/Path.cpp:134
> > +#if !PLATFORM(CHROMIUM) && !PLATFORM(MAC)
> >      if (rect.width() < topLeftRadius.width() + topRightRadius.width()
> 
> Random platform #ifdefs are never a good thing in shared platform code. It's impossible to know, by reading this, why Chromium or Mac behave differently.

I see. I completely agree with you.

So I investigated how Firefox treats border-radiuses like this and implemented the logic in my new patch.
Now there are no #ifdefs in Path.cpp.

Best regards,
Takashi Sakamoto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.