[Webkit-unassigned] [Bug 88586] New: rebaseline from garden-o-matic leaves N processes each time it is run

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88586

           Summary: rebaseline from garden-o-matic leaves N processes each
                    time it is run
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tony at chromium.org
                CC: ojan at chromium.org, dpranke at chromium.org


I get 16 left over python processes each time I run Rebaseline from garden-o-matic.  It looks like we never close our multiprocess.Pools in run_in_parallel.

http://docs.python.org/library/multiprocessing.html#multiprocessing.pool.multiprocessing.Pool.close

Changing run_in_parallel to:

        pool = multiprocessing.Pool(processes=processes)
        results = pool.map(_run_command_thunk, command_lines_and_cwds)
        pool.close()
        return results

Seems to work, but I get an exception for each command:

Exception RuntimeError: RuntimeError('cannot join current thread',) in <Finalize object, dead> ignored

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.