[Webkit-unassigned] [Bug 88070] [Gtk] Process Gtk 3.4 smooth scroll events properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88070





--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2012-06-07 15:04:13 PST ---
(From update of attachment 146315)
View in context: https://bugs.webkit.org/attachment.cgi?id=146315&action=review

This seems ready to go to me, though I have a couple lingering questions about some of the changes you made to the Skipped files.

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:76
> +                gdk_event_get_scroll_deltas(reinterpret_cast<GdkEvent *>(event), &deltaX, &deltaY);

This is a bit of a nit, but you can just write: reinterpret_cast<GdkEvent*>(event) (without the space).

> LayoutTests/platform/gtk-wk2/Skipped:416
> +fast/events/scroll-in-scaled-page-with-overflow-hidden.html

I'm not sure I understand this change. The patch causes this test to start failing?

> LayoutTests/platform/wk2/Skipped:-1031
> -# WTR needs an implementation for eventSender.continuousMouseScrollBy
> -# https://bugs.webkit.org/show_bug.cgi?id=69417
> -fast/events/wheelevent-direction-inverted-from-device.html
> -

I'm not sure it's correct to unskip this test unless it's also skipped in the platform-specific files.  I think perhaps you may need to add this to LayoutTests/platform/qt-5.0-wk2/Skipped if Qt also doesn't have support for continuous scrolls.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.