[Webkit-unassigned] [Bug 88524] New: check-webkit-style needs to be taught about <public/Foo.h>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88524

           Summary: check-webkit-style needs to be taught about
                    <public/Foo.h>
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kinuko at chromium.org


Currently check-webkit-style considers any headers included with <> (i.e. is_system==True) as non-primary headers, but some platform implementation includes its primary header placed under Platform/.../public with <>.  check-webkit-style warns include_order for those files.

Examples:
Source/WebCore/platform/chromium/support/WebHTTPBody.cpp
Source/WebCore/platform/chromium/support/WebHTTPLoadInfo.cpp
Source/WebCore/platform/chromium/support/WebURL.cpp
Source/WebCore/platform/chromium/support/WebURLError.cpp
Source/WebCore/platform/chromium/support/WebURLRequest.cpp
Source/WebCore/platform/chromium/support/WebURLResponse.cpp

Running check-webkit-style on any of these files generates include_order error:
Source/WebCore/platform/chromium/support/WebHTTPBody.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.