[Webkit-unassigned] [Bug 88521] New: Qt 5 Webkit builds appear to require -DHAVE_QT5=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88521

           Summary: Qt 5 Webkit builds appear to require -DHAVE_QT5=1
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebKit Qt
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: steveire at gmail.com


Qt 5 Webkit builds appear to require -DHAVE_QT5=1 if downstreams want to use QtWebkit with Qt 5. This is a bug because:

* The macro name is too generic. It should at least be prefixed with WEBKIT_ 
* The standard QT_VERSION check should be used instead, so that downstreams don't have to add any defines at all to use webkit with Qt 5.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.