[Webkit-unassigned] [Bug 88087] [SOUP] WebSoupRequestManager should handle loading errors and zero-length replies

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 23:34:31 PDT 2012


--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-06-06 23:34:30 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > > It would make sense for this to return a GRefPtr to avoid a leak.
> > The only user of that method already adopts the ref, so it's not leaked.
> Returning a RefPtr here would make it less likely for someone to misuse the new reference.

fair enough.

> > Yes, it's unlikely but possible. If there are more than one chunk messages sent by the UI process and the first one fails. The data is removed from the map, and a message is sent to the UI process to stop sending more chunk messages. The next chunk message already sent will be silently ignored if there's no data for for it in the request map.
> That makes sense. Do you mind putting that in a comment before the early return?


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list