[Webkit-unassigned] [Bug 88398] [Skia] Use light gray for grammar markers.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 19:28:20 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88398





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-06 19:28:19 PST ---
(From update of attachment 145951)
View in context: https://bugs.webkit.org/attachment.cgi?id=145951&action=review

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:560
> -            0xFF << SK_A32_SHIFT | 0x50 << SK_R32_SHIFT | 0x50 << SK_G32_SHIFT | 0x50 << SK_B32_SHIFT, // Opaque gray.
> +            0xFF << SK_A32_SHIFT | 0xC0 << SK_R32_SHIFT | 0xC0 << SK_G32_SHIFT | 0xC0 << SK_B32_SHIFT, // Opaque gray.
>          };
>          static const uint32_t antiColors[2] = {
>              0x60 << SK_A32_SHIFT | 0x60 << SK_R32_SHIFT, // Semitransparent red
> -            0xFF << SK_A32_SHIFT | 0x30 << SK_R32_SHIFT | 0x30 << SK_G32_SHIFT | 0x30 << SK_B32_SHIFT, // Semitransparent gray
> +            0xFF << SK_A32_SHIFT | 0xC0 << SK_R32_SHIFT | 0xC0 << SK_G32_SHIFT | 0xC0 << SK_B32_SHIFT, // Semitransparent gray

Should we have if-def for mac?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list