[Webkit-unassigned] [Bug 30143] GraphicsContextSkia draws paths incorrectly
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 6 17:17:15 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=30143
Silvia Pfeiffer <silviapf at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |silviapf at chromium.org
--- Comment #1 from Silvia Pfeiffer <silviapf at chromium.org> 2012-06-06 17:17:15 PST ---
This is happening in Skia because we only draw rounded borders when the rounding fits into the rectangle.
See this code in Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp :
Function: void GraphicsContext::fillRoundedRect()
if (topLeft.width() + topRight.width() > rect.width()
|| bottomLeft.width() + bottomRight.width() > rect.width()
|| topLeft.height() + bottomLeft.height() > rect.height()
|| topRight.height() + bottomRight.height() > rect.height()) {
// Not all the radii fit, return a rect. This matches the behavior of
// Path::createRoundedRectangle. Without this we attempt to draw a round
// shadow for a square box.
fillRect(rect, color, colorSpace);
return;
}
Thus, when the volume slider is too close to 0% or to 100%, the rectangle gets too small to be able to draw the arcs.
See bug https://bugs.webkit.org/show_bug.cgi?id=23882 .
I don't quite know how to implement the rounded fillers now. Any suggestions?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list