[Webkit-unassigned] [Bug 80879] Mock scrollbars differ by 1px in DRT vs. WKTR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80879


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rniwa at webkit.org




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-06 14:17:48 PST ---
(In reply to comment #10)
> (From update of attachment 145639 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145639&action=review
> 
> > Source/WebCore/platform/ScrollbarThemeComposite.cpp:245
> > +    int length = round(proportion * trackLen);
> 
> Since we are rounding a float and want the result to be an int, the best function is lroundf.
> 
> By using round, we are converting from float to double, then rounding to another double, then converting to an int.
> 
> If we used lroundf, we would pass in a float, then get a long as a result, and then we would be good, since long and int are the same type on all the compilers that are used to compile WebKit.

I wonder if this contributed to the large number of test failures in Chromium...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.