[Webkit-unassigned] [Bug 53003] Web Inspector: [JSC] implement setting breakpoints by line:column

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53003





--- Comment #21 from Vsevolod Vlasov <vsevik at chromium.org>  2012-06-06 13:04:42 PST ---
(From update of attachment 145731)
View in context: https://bugs.webkit.org/attachment.cgi?id=145731&action=review

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:160
> +    unsigned hitBreaksCount = m_lastHitScriptBreakpoints.size();

I don't understand the purpose of m_lastHitScriptBreakpoints - isn't it always empty at this point?

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:179
> +    m_hitScriptBreakpoint = breaksVector.at(i);

Why don't you return m_hitScriptBreakpoint in an output parameter instead of adding a mutable field?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.