[Webkit-unassigned] [Bug 84597] InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 12:13:00 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=84597


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #146011|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-06 12:12:59 PST ---
(From update of attachment 146011)
View in context: https://bugs.webkit.org/attachment.cgi?id=146011&action=review

Please fix nits below:

> Source/WebCore/ChangeLog:17
> +        Comparison between start and end VisiblePositions will fail when a position inside
> +        a paragraph is compared with one at the start of the paragraph.
> +
> +        This fix thus converts the end VisiblePosition (which could be inside the paragraph)
> +        to the start of the paragraph thereby enabling a proper comparison of start and end
> +        positions.

We normally put these long description after "Reviewed by" before the list of tests wrapped in blank lines.

> LayoutTests/ChangeLog:12
> +        This test verifies removing of an (un)ordered list on a selection consisting of multiple
> +        list items (paragraphs) when the end point of the selection points to the end of the last
> +        list item; followed by another paragraph not part of the selection/list.

This should probably go after "Reviewed by" line but before the list of files.

> LayoutTests/editing/execCommand/remove-list-from-multi-list-items.html:3
> +<p>This test verifies removing of an (Un)OrderedList on a selection consisting of multiple list items (paragaraphs) when the end point of the selection points to the end of the last list item; followed by another paragraph not part of the selection/list.</p>

You need to pass this to Markup.description.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list