[Webkit-unassigned] [Bug 69417] WTR needs an implementation for eventSender.continuousMouseScrollBy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69417





--- Comment #3 from Balazs Kelemen <kbalazs at webkit.org>  2012-06-06 10:29:32 PST ---
(From update of attachment 146019)
View in context: https://bugs.webkit.org/attachment.cgi?id=146019&action=review

Generally looks good, but there are some things to complain about.

> Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:33
> +        void continuousMouseScrollBy (in long x, in long y, in [Optional] boolean paged);

Extra space after function name.

> Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:395
> +    gdk_event_set_device(event, gdk_device_manager_get_client_pointer(gdk_display_get_device_manager(gdk_window_get_display(event->scroll.window))));
> +
> +    // For more than one tick in a scroll, we need smooth scroll event
> +#if GTK_CHECK_VERSION(3, 3, 18)
> +    if ((horizontal && vertical) || horizontal > 1 || horizontal < -1 || vertical > 1 || vertical < -1) {
> +        event->scroll.direction = GDK_SCROLL_SMOOTH;
> +        event->scroll.delta_x = -horizontal;
> +        event->scroll.delta_y = -vertical;
> +
> +        sendOrQueueEvent(event);
> +        return;
> +    }
> +#endif

Why did you have to change on this function? It was already there. Please describe it in the changelog.

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:401
> +void EventSenderProxy::continuousScrollBy(int x, int y, bool paged)
> +{

Why is it not continuousMouseScrollBy? Have you build it on Mac?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.