[Webkit-unassigned] [Bug 88070] [Gtk] Process Gtk 3.4 smooth scroll events properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88070





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-06-06 09:10:03 PST ---
(From update of attachment 146041)
View in context: https://bugs.webkit.org/attachment.cgi?id=146041&action=review

This change looks good, but I'm slightly confused how you are able to unskip tests because of this change, as you didn't modify the DRT. I think it makes sense to now implement continuousMouseScrollBy if possible.

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:83
> +        case GDK_SCROLL_SMOOTH:
> +            {
> +                gdouble deltaX, deltaY;
> +                gdk_event_get_scroll_deltas((GdkEvent *) event,
> +                                            &deltaX,
> +                                            &deltaY);
> +                m_deltaX = -deltaX;
> +                m_deltaY = -deltaY;
> +            }
> +            break;

I think it makes more sense for the curly brace to be after GDK_SCROLL_SMOOTH, if possible, like this:

case GDK_SCROLL_SMOOTH: {
    gdouble deltaX, deltaY;
    ...
}

It matches more closely to WebKit style. You should use a static_cast for event instead of a C-style cast here. Also lines in WebKit typically go out to about 120 characters.

> Source/WebKit2/Shared/gtk/WebEventFactory.cpp:158
> +    case GDK_SCROLL_SMOOTH:
> +        {

Same comment here as above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.