[Webkit-unassigned] [Bug 68509] [EFL] Implementation of Unit Tests framework for the WebKit-Efl port

Wed Jun 6 08:13:40 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=68509

--- Comment #34 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-06-06 08:13:39 PST ---
(From update of attachment 146014)
View in context: https://bugs.webkit.org/attachment.cgi?id=146014&action=review

> Source/WebKit/PlatformEfl.cmake:318
> +    "${WEBKIT_DIR}/efl/tests/src/UnitTestLauncher"

UnitTestLauncher does not exists

> Source/WebKit/PlatformEfl.cmake:320
> +    "${WTF_DIR}/ForwardingHeaders"

${WTF_DIR}/ForwardingHeaders does not exists

> Source/WebKit/PlatformEfl.cmake:370
> +    ADD_EXECUTABLE(bin/${testName} ${WEBKIT_EFL_TEST_DIR}/${testName}.cpp ${WEBKIT_EFL_TEST_DIR}/EwkTestsMain.cpp)

IMO is important to prefix the tests with something. We will get here:

$ ls WebKitBuild/Debug/bin/
DumpRenderTree
EWebLauncher
EwkViewUriGetTest
EwkViewEditableGetTest
ImageDiff
jsc

I personally would like to see something more intuitive like:

$ ls WebKitBuild/Debug/bin/
DumpRenderTree
EWebLauncher
ImageDiff
jsc
test_EwkViewUriGetTest
test_EwkViewEditableGetTest

> Source/WebKit/efl/tests/UnitTestUtils/EWKTestBase.h:51
> +#define EFL_SHUTDOWN()  \

EFL_SHUTDOWN* macros are not in use.

> Source/WebKit/efl/tests/default_test_page.html:1
> +<HTML>

I still don't like the idea of mixing test "resources" with source code. IMO it should be placed in:
Source/WebKit/efl/tests/resources/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.