[Webkit-unassigned] [Bug 87336] [WebSocket] WebSocket object should fire error event when WebSocket server can't be connected.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 07:39:53 PDT 2012


--- Comment #16 from Takashi Toyoshima <toyoshim at chromium.org>  2012-06-06 07:39:52 PST ---
(From update of attachment 145080)
View in context: https://bugs.webkit.org/attachment.cgi?id=145080&action=review

I looked over this patch and left some comments.
I should understand details, so I'll take another look tomorrow.

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:234
> +        }

Here, you try to call didReceiveMessageError() at most once.
But I notice that didReceiveMessageError() is invoked from many places in this source code.
This looks another original bug on WebSocketChannel (Or, is this introduced at previous change?)

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:351

Unfortunately, I have not enough understanding on other ports behaviors.
Why do you need special handling for chromium port?

> Source/WebKit/chromium/src/SocketStreamHandle.cpp:-156
> -        m_socket.clear();

This part of change looks right.

> LayoutTests/ChangeLog:15
> +

It'd be better to have worker version of this test.
As you may already know, worker thread handling in WebSocketChannel is a little complicated.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list