[Webkit-unassigned] [Bug 88411] FileAPI: If type consists of non-ASCII characters in Blob constructor, it should throw a SyntaxError.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88411





--- Comment #4 from Li Yin <li.yin at intel.com>  2012-06-06 07:36:20 PST ---
(In reply to comment #2)
> (From update of attachment 146013 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=146013&action=review
> 
> > Source/WebCore/bindings/js/JSBlobCustom.cpp:108
> > +            setDOMException(exec, SYNTAX_ERR);
> > +            return JSValue::encode(JSValue());
> 
> SYNTAX_ERR and SyntaxError are different. You need to use 'return throwVMError(exec, createSyntaxError(exec, "..."));'
> 
> > Source/WebCore/bindings/v8/custom/V8BlobCustom.cpp:106
> > +            return throwError(SYNTAX_ERR, args.GetIsolate());
> 
> Ditto. You need to use 'return V8Proxy::throwError(V8Proxy::SyntaxError, "...");'

Thanks for your review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.