[Webkit-unassigned] [Bug 88312] [EFL] Remove Ewk_View_Smart_Data and Ewk_View_Smart_Class from public header.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88312





--- Comment #3 from Tomasz Morawski <t.morawski at samsung.com>  2012-06-06 02:51:55 PST ---
(In reply to comment #2)
> Would be nice to explain "why" and not "what". What I understood from the patch is: the API was public but only used by DRT. You made DRT include a private header instead, which IMO is not recommended.
Yes, I also don't like that that the DRT include some private files. But I can understand that the DRT is not typical application it is an internal WebKit's tool that have to include some private headers. Anyway the ewk_private.h can be removed from include files now. I have just chacked that ewk_private.h is not needed in the DRT now.

I personally think that end application like browser doesn't need to make custom view class. Moreover, it looks like for me that the _Ewk_View_Smart_Class and _Ewk_View_Smart_Data struct ware deffined only inside ewk_view.h file because there ware not private headers file before. But I will not defend this patch. :) 

> > Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:34
> > +#include "ewk_view_private.h"
> 
> Looks to me that DRT needs the private methods to select the backing storage. Can it be done differently like in EWebLauncher? I know we are already including ewk_private.h (which is quite minimal now), but it should also be fixed.

The DRT uses _Ewk_View_Smart_Class structure make custom subclass of View_Smart_Class. It fills that structure to have custom methods. Please see Evas_Object* drtViewAdd(Evas* evas) function. The EWebLauncher uses deffined by ewk Views without change them.

Thanks for your comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.