[Webkit-unassigned] [Bug 88312] [EFL] Remove Ewk_View_Smart_Data and Ewk_View_Smart_Class from public header.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 6 01:52:30 PDT 2012


--- Comment #2 from Thiago Marcos P. Santos <tmpsantos at gmail.com>  2012-06-06 01:52:28 PST ---
(From update of attachment 145723)
View in context: https://bugs.webkit.org/attachment.cgi?id=145723&action=review

> Source/WebKit/efl/ChangeLog:10
> +        file.

Would be nice to explain "why" and not "what". What I understood from the patch is: the API was public but only used by DRT. You made DRT include a private header instead, which IMO is not recommended.

> Source/WebKit/efl/ewk/ewk_view.cpp:2679
> + * @param o view object to get the internal data

Should be @param ewkView

> Source/WebKit/efl/ewk/ewk_view.cpp:2681
> + * @return the internal data of @a o, or @c 0 on failure


> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:34
> +#include "ewk_view_private.h"

Looks to me that DRT needs the private methods to select the backing storage. Can it be done differently like in EWebLauncher? I know we are already including ewk_private.h (which is quite minimal now), but it should also be fixed.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list