[Webkit-unassigned] [Bug 84597] InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84597


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145788|review?                     |review-
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-05 22:30:38 PST ---
(From update of attachment 145788)
View in context: https://bugs.webkit.org/attachment.cgi?id=145788&action=review

r- because we need a test for this.

> Source/WebCore/ChangeLog:13
> +        Comparison between start and end VisiblePositions is not proper since the end
> +        VisiblePosition also contains the offset, whereas comparison is made with a
> +        VisiblePosition which is at the start of the paragraph being compared i.e. with
> +        offset always as zero.

This isn't really accurate description of what's happening. The problem is that we're sometimes comparing a position inside a paragraph with a position at the start of the paragraph.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.