[Webkit-unassigned] [Bug 88197] ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88197





--- Comment #6 from Joe Thomas <joethomas at motorola.com>  2012-06-05 17:16:04 PST ---
(In reply to comment #4)
> (From update of attachment 145870 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145870&action=review
> 
Thanks for the review.

> > Source/WebCore/ChangeLog:9
> > +        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
> > +        to true while it handles width/height of Percentage types.
> 
> It's an undocumented convention that we wrap long lines in change log entries. I suggest adding a new line character after "RenderSVGRoot::computeIntrinsicRatioInformation" in line 8 such that we move the phrase "sets isPercentageIntrinsicSize" onto line 9. You may also want to consider adding a remark that explains that RenderSVGRoot extends RenderReplaced so as to more explicitly imply that RenderSVGRoot overrides RenderReplaced::computeIntrinsicRatioInformation().
> 
> Nit: Percentage => percentage
> (as it's not a proper noun)
> 
Done

> > Source/WebCore/rendering/RenderReplaced.cpp:-293
> > -    ASSERT(!isPercentageIntrinsicSize);
> 
> Would it make sense to assert !isPercentageIntrinsicSize when intrinsicRatio is non-zero?
> 
Yes, I think that is better. Changed.

> > LayoutTests/ChangeLog:9
> > +        ASSERT(!isPercentageIntrinsicSize) is not correct as RenderSVGRoot::computeIntrinsicRatioInformation sets isPercentageIntrinsicSize
> > +        to true while it handles width/height of Percentage types.
> 
> Ditto.
> 
> > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:7
> > +<svg style= "max-height:5%"> </svg>
> 
> Nit: There's a space after the '=' in this line.  I suggest we remove this space so as to be consistent with the spacing (or lack of) on the left side of the equality sign.
> 
> > LayoutTests/svg/in-html/svg-assert-failure-percentage.html:8
> > +NO Assert!
> 
> This output message isn't formatted well. On another note, maybe the following text would be more description:
> 
> This test PASSED if it doesn't cause an assertion failure.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.