[Webkit-unassigned] [Bug 88294] FileAPI: Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88294


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145732|review?                     |review-
               Flag|                            |




--- Comment #7 from Kenneth Russell <kbr at google.com>  2012-06-05 14:16:23 PST ---
(From update of attachment 145732)
View in context: https://bugs.webkit.org/attachment.cgi?id=145732&action=review

It may be worth supporting the Blob constructor taking ArrayBuffer for a brief period of time, warning that the old constructor is deprecated. See Source/WebCore/Modules/indexeddb/IDBIndex.cpp for an example.

The patch looks OK overall; I'm r-'ing it due to the need for a test of DataView.

> LayoutTests/ChangeLog:8
> +        Change ArrayBuffer into ArrayBufferView in Blob constrcuting function.

typo: constrcuting

> LayoutTests/fast/files/script-tests/blob-constructor.js:68
> +var blobObj = new Blob([new Int32Array(100)]);

Please test DataView too. DataView is the primary view intended to be used for file and network I/O.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.