[Webkit-unassigned] [Bug 87993] window.internals is not good for changing persistent settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87993


Jesus Sanchez-Palencia <jesus at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jesus at webkit.org




--- Comment #2 from Jesus Sanchez-Palencia <jesus at webkit.org>  2012-06-05 14:11:36 PST ---
Hi! I will try to understand the issue related to this bug a bit further to see if I can help.

(In reply to comment #1)
> (In reply to comment #0)
> > 1. Changing a setting in one window.internals.settings object affects all frames in a page, but does not work across secondary windows. This is inconsistent.
> > 
> Right.

Any ideas? What would be more consistent, not affecting all frames in a page or working across secondary windows?


> 
> > 2. If a test navigates to a different URL (with waitUntilDone/notifyDone), settings are restored from last document's InternalSettings instead of first one's, so changes made in first one just leak to future tests.

Due to m_settings->restoreTo(document->page()->settings()) in Internals::reset(), right? We could fix this by keeping a reference to the first document and then using it to restore the settings, but is this what we want?


> > 
> > 3. Code design is not very clear. Settings are per-page, yet many Internals methods take Document, Frame or a global context.
> This is also true. InternalSettings started from simple extraction from 
> Internals object, which had no state at that time.
> We could have better lifecycle representation around here.

What do you mean by better lifecycle representation more specifically?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.