[Webkit-unassigned] [Bug 88344] New: fix FastMalloc.cpp compile error for 64 bit machines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 5 10:35:40 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88344

           Summary: fix FastMalloc.cpp compile error for 64 bit machines
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Trivial
          Priority: P4
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: alex.christensen at flexsim.com


Source/WTF/wtf/FastMalloc.cpp does not compile for 64 bit machines.  Line 2477 tries to make an array of size 0.  I suggest this line be changed from 

  char pad_[(64 - (sizeof(TCMalloc_Central_FreeList) % 64)) % 64];

(which evaluates to 0 when sizeof(TCMalloc_Central_FreeList) is a multiple of 64) to this:

  char pad_[64 - (sizeof(TCMalloc_Central_FreeList) % 64)];

This will not change anything for a 32 bit machine, and it will create a 64 byte pad on a 64 bit machine, which will use a little extra memory, but it will compile correctly and still pad to a multiple of 64 bytes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list