[Webkit-unassigned] [Bug 88292] [GTK] Build fix for Accelerated Compositing with OpenGL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88292


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145709|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-06-05 08:10:04 PST ---
(From update of attachment 145709)
View in context: https://bugs.webkit.org/attachment.cgi?id=145709&action=review

Looks good, but please fix the include order when landing.

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h:28
> +
> +#if USE(GRAPHICS_SURFACE)
>  #include "GraphicsSurface.h"
> +#endif
> +

You should now move this include below the rest of them, so it should be like:

#include "FloatRect.h"
#include "Image.h"
#include "TextureMapper.h"
#include "TextureMapperPlatformLayer.h"
#include <wtf/RefPtr.h>

#if USE(GRAPHICS_SURFACE)
#include "GraphicsSurface.h"
#endif

> Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:28
>  #include "GraphicsContext.h"
> +
> +#if USE(GRAPHICS_SURFACE)
>  #include "GraphicsSurface.h"
> +#endif
> +

The same thing is necessary here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.