[Webkit-unassigned] [Bug 85475] run-qtwebkit-tests hangs with -j1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85475


Peter Gal <galpeter at inf.u-szeged.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |galpeter at inf.u-szeged.hu




--- Comment #3 from Peter Gal <galpeter at inf.u-szeged.hu>  2012-06-05 02:07:36 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=145726&action=review

> Tools/Scripts/run-qtwebkit-tests:158
>      log.info("Finished %s", test_suite.test_file_name())
> +    timer.cancel()
>      return test_suite

This is not in the correct place. If timeout is not set the 'timer' will be a "None" value, calling cancel() on that will result an AttributeError. You should check if the timer is set to a valid object. So I would give an r- for now (sadly I can't set that flag).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.