[Webkit-unassigned] [Bug 73544] [EFL] Support for Web Notification.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 4 19:35:13 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #47 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-04 19:35:12 PST ---
(From update of attachment 145673)
View in context: https://bugs.webkit.org/attachment.cgi?id=145673&action=review

>>> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:53
>>> +                    printf("REPLACING NOTIFICATION %s\n", iter->first->isHTML() ? iter->first->url().string().utf8().data() : iter->first->title().utf8().data());
>> 
>> Remove printf(). If you wanna print debug log, use LOG_XXX. Or, if you wanna pass layout test, you should move this printf to DRT side.
> 
> QT port is implemented like this.
> In the chromium port, there are additional classes only for the layout tests.
> But, I think if I make additional classes for the layout tests, It's not a tests for real implementation. That's why I use printf in the middle of implementation like QT.
> How do you think about this?

If you follow QT implementation, I don't mind to do it. However, this patch is huge, I feel difficult to review this detail.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list