[Webkit-unassigned] [Bug 73544] [EFL] Support for Web Notification.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73544





--- Comment #44 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-04 18:34:43 PST ---
(From update of attachment 145673)
View in context: https://bugs.webkit.org/attachment.cgi?id=145673&action=review

I think this patch is a little huge. If possible, can you divide this patch into smaller's ?

> LayoutTests/platform/efl/TestExpectations:717
> +// Refactor notification tests requiring file:// permission.

Why do you use // in front of *permission* comment? Do not make unneeded comment style.

> LayoutTests/platform/efl/TestExpectations:726
> +// Efl doesn't support to simulateDesktopNotificationClick.

Efl -> EFL.

> Source/WebCore/ChangeLog:8
> +        Change requestPermission can be processed when argument is null on the JSC.

Change requestPermission -> To change requestPermission ?

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:53
> +                    printf("REPLACING NOTIFICATION %s\n", iter->first->isHTML() ? iter->first->url().string().utf8().data() : iter->first->title().utf8().data());

Remove printf(). If you wanna print debug log, use LOG_XXX. Or, if you wanna pass layout test, you should move this printf to DRT side.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:63
> +    evas_object_smart_callback_call(m_view, "notification,show", static_cast<void*>(ewkNotification));

If you add new signal, you should add signal description to ewk_view.h.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:68
> +            printf("DESKTOP NOTIFICATION: contents at %s\n", notification->url().string().utf8().data());

ditto.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:70
> +            printf("DESKTOP NOTIFICATION:%s icon %s, title %s, text %s\n",

ditto.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:90
> +            printf("DESKTOP NOTIFICATION CLOSED: %s\n", notification->url().string().utf8().data());

ditto.

> Source/WebKit/efl/WebCoreSupport/NotificationPresenterClientEfl.cpp:92
> +            printf("DESKTOP NOTIFICATION CLOSED: %s\n", notification->title().utf8().data());

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.