[Webkit-unassigned] [Bug 85041] [EFL][WK2] Compile webkit1 and webkit2 by default.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85041





--- Comment #13 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-06-04 18:15:13 PST ---
(In reply to comment #12)

EWS is compiling webkit using "Tools/Scripts/build-webkit --efl". If there is no problems when you build WebKit with your patches, I think EWS also won't have problems.(In reply to comment #12)
> > It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt.
> 
> Hm, I've ran webkit build like on EWS "perl ./Tools/Scripts/build-webkit --release --efl" and both webkit1 and webkit2 were built. In CMakeCache.txt I have "ENABLE_WEBKIT2:UNINITIALIZED=On". Is this right command, or EWS makes something extra?

If the feature is not defined in WebKitFeatures, UNINITIALIZED is added to CMakeCache.txt. But, I think we don't need to add ENABLE_WEBKIT2 to WebKitFeatures yet.

http://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake#L14

I ran webkit1 and webkit2 with this patch. Then, I could get both libewebkit2.so and libewebkit.so. It seems to me there is no problem. 

Kubo, do you think ENABLE_WEBKIT2 is off yet ?

Mariusz, as kubo said, you need to use uppercase for "On".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.