[Webkit-unassigned] [Bug 87805] [Shadow DOM] <style> inside Shadow subtree should be scoped inside the subtree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87805


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145543|review?                     |review-
               Flag|                            |




--- Comment #2 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-06-04 09:30:22 PST ---
(From update of attachment 145543)
View in context: https://bugs.webkit.org/attachment.cgi?id=145543&action=review

This looks good overall, I think we need a bit more test coverage:
1) at least make sure that all of the state transitions are accounted for
2) look at nested shadow dom and multiple shadow roots per element.

> Source/WebCore/html/HTMLStyleElement.cpp:55
>      , m_isRegisteredWithScopingNode(false)
> +    , m_scoped(false)

Can we not combine these two? Is there ever a situation when you are scoped, but have no scoping node?

> Source/WebCore/html/HTMLStyleElement.cpp:96
> +void HTMLStyleElement::updateForStyleScoped()

Would it work better if we name it as a notification to react and combine into one method?: styleScopedUpdated(attribute.isNull());

> LayoutTests/fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html:28
> +    debug("E: " + document.defaultView.getComputedStyle(e, null).getPropertyValue('color')); /* red */
> +    debug("E: " + document.defaultView.getComputedStyle(e, null).getPropertyValue('border')); /* blue 1px border */
> +    debug("F: " + document.defaultView.getComputedStyle(f, null).getPropertyValue('color')); /* black */
> +    debug("F: " + document.defaultView.getComputedStyle(e, null).getPropertyValue('border')); /* blue 1px border */

this can be a function.

> LayoutTests/fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html:35
> +    document.body.offsetLeft;

Why do we need this here?

> LayoutTests/fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html:42
> +    document.body.offsetLeft;

.. or here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.