[Webkit-unassigned] [Bug 88055] [BlackBerry] Support Do Not Track HTTP Header.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88055





--- Comment #5 from Rob Buis <rwlbuis at gmail.com>  2012-06-04 07:29:01 PST ---
(From update of attachment 145542)
View in context: https://bugs.webkit.org/attachment.cgi?id=145542&action=review

The code looks good to me. But I think we need to make sure chromium folks like this as well, and that nobody is doing duplicated work on this feature?

> Source/WebCore/platform/network/blackberry/NetworkManager.cpp:79
> +    request.initializePlatformRequest(platformRequest, frame.loader() && frame.loader()->client() && static_cast<FrameLoaderClientBlackBerry*>(frame.loader()->client())->cookiesEnabled(), static_cast<FrameLoaderClientBlackBerry*>(frame.loader()->client())->doNotTrackEnabled(), isInitial, redirectCount);

Maybe by now you can store frame.loader()->client() in a temp variable since you reference it a lot, also might be able to get rid of the static_cast that way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.