[Webkit-unassigned] [Bug 87993] window.internals is not good for changing persistent settings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87993


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |morrita at google.com




--- Comment #1 from Hajime Morrita <morrita at google.com>  2012-06-04 03:33:06 PST ---
(In reply to comment #0)
> 1. Changing a setting in one window.internals.settings object affects all frames in a page, but does not work across secondary windows. This is inconsistent.
> 
Right.

> 2. If a test navigates to a different URL (with waitUntilDone/notifyDone), settings are restored from last document's InternalSettings instead of first one's, so changes made in first one just leak to future tests.
> 
> 3. Code design is not very clear. Settings are per-page, yet many Internals methods take Document, Frame or a global context.
This is also true. InternalSettings started from simple extraction from 
Internals object, which had no state at that time.
We could have better lifecycle representation around here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.