[Webkit-unassigned] [Bug 77899] IETC: FileList.item(-1) should return null instead of raising

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77899





--- Comment #18 from Kinuko Yasuda <kinuko at chromium.org>  2012-06-04 00:09:08 PST ---
(From update of attachment 145513)
View in context: https://bugs.webkit.org/attachment.cgi?id=145513&action=review

> LayoutTests/fast/files/file-list-test.html:25
> +    shouldBeEqualToString("files.item(0).name", "UTF8.txt");

One more comment.  We're testing the 'files' against constant values in this handler while the handler is registered for multiple test cases now (though the only non-empty test case is [UTF8.txt, UTF8-2.txt]).  If we really want to make this handler generic we should give the expected values also from caseArray, or maybe in this case we can just drop the caseArray but instead calling each case directly with different handler?  Like:

doTest(["resources/UTF8.txt", "resources/UTF8-2.txt"], onInputFileChange);
doTest([], shouldNotBeCalled);

(By the way do we really need to test empty file list case in this test?  It doesn't look to be a part of FileList tests)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.