[Webkit-unassigned] [Bug 88208] New: REGRESSION(r117929) [Forms] input type=number thinks 0 is not a number

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 3 20:52:16 PDT 2012


           Summary: REGRESSION(r117929) [Forms] input type=number thinks 0
                    is not a number
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
               URL: data:text/html,<input type=number min=0 max=50 step=1>
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yosin at chromium.org

Import from http://crbug.com/130910

This is regression of r117929, it seems he didn't change following code:

bool NumberInputType::isAcceptableValue(const String& proposedValue)
    String standardValue = convertFromVisibleValue(proposedValue);
    return standardValue.isEmpty() 
        || parseToDoubleForNumberType(standardValue, 0); // Forgot to change

Before r117929, parseToDoubleForNumberType returns bool which indicates true is valid number or not.
After r117929, the return value is number or NaN. So, value 0 means false in this case == not acceptable value.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list