[Webkit-unassigned] [Bug 88206] New: DFG arguments simplification should have rationalized handling of TearOffArguments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88206

           Summary: DFG arguments simplification should have rationalized
                    handling of TearOffArguments
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fpizlo at apple.com


Here's what should happen: the existence of TearOffArguments should have no effect on the conclusion reached by arguments simplification.  Optimally, arguments simplification should eliminate the TearOffArguments opcode in those cases where it eliminates arguments creation.  But that's not necessary for correctness.

Currently, arguments simplification completely ignores TearOffArguments because it neglects to consider accesses to the unmodified arguments register.  By some manner of dumb luck, this ends up "just working" because TearOffArguments is the only opcode that would explicitly read the unmodified arguments register.  Of course, it works in a sub-optimal way, because the TearOffArguments op ends up still being emitted.

This code should be rationalized and made to work in a sensible way.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.