[Webkit-unassigned] [Bug 88183] Implement layoutTestController using IDL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 3 11:15:24 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88183





--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2012-06-03 11:15:22 PST ---
(In reply to comment #6)
> (From update of attachment 145480 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145480&action=review
> 
> > Tools/DumpRenderTree/LayoutTestController.h:445
> > +class TestRunner : public WebCore::TestRunnerBase {
> 
> I was expecting LayoutTestController to inherit from TestRunnerBase.  As written, you're going to need to forward every call to m_controller...

It turns out LayoutTestController doesn't implement methods like dumpAsText or waitUntilDone. Instead, static callback functions implement those.

So my current plan is to implement TestRunner class as a proxy for LayoutTestController, transition to use IDL, and then merge the existing LayoutTestController into TestRunner.  I mean... I could attempt to do all of them at once but the patch is going to be huge then.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list