[Webkit-unassigned] [Bug 87774] REGRESSION (r105515): reflection masks are truncated at zoom levels < 1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87774





--- Comment #8 from Beth Dakin <bdakin at apple.com>  2012-06-01 12:57:48 PST ---
(In reply to comment #6)
> (From update of attachment 145361 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=145361&action=review
> 
> > Source/WebCore/ChangeLog:17
> > +        * rendering/RenderBoxModelObject.cpp:
> 
> Additional newline here.
> 

Added.

> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1034
> > +    IntSize imageIntrinsicSize = calculateImageIntrinsicDimensions(image, positioningAreaSize, true);
> 
> Maybe an enum instead of an incomprehensible bool argument?
> 

I knew someone was going to suggest this. And I only didn't do it that way from the start because I suck so much at naming things. How about:

enum ShouldScaleByEffectiveZoom { ShouldScale, ShouldNotScale }

Thoughts? Suggestions?

> > Source/WebCore/rendering/RenderBoxModelObject.cpp:1251
> > -    int imageWidth = imageSize.width() / style->effectiveZoom();
> > -    int imageHeight = imageSize.height() / style->effectiveZoom();
> > +    int imageWidth = imageSize.width();
> > +    int imageHeight = imageSize.height();
> 
> Have you quadruple checked that this doesn't break the apple.com top bar again (a la https://bugs.webkit.org/show_bug.cgi?id=76249)?
> 

I have! I ran lots of layout tests and pixel tests too.

> > LayoutTests/ChangeLog:5
> > +        -and corresponding-
> 
> I don't know that the -and corresponding- is necessary, but OK :D

It's my thang! Just ask mitzpettel. :-P

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.